Open
Conversation
Contributor
|
if you insist on somehow fixing this :) then instead of yield hack should have gzip outputting into lwt io channel directly, not separate buffer |
mfp
requested changes
May 10, 2024
| | "" -> Lwt.return_unit | ||
| | s -> | ||
| let%lwt s = match c.req with | ||
| | Ready { encoding=Gzip; _ } -> Gzip_io.string_lwt s |
There was a problem hiding this comment.
This doesn't seem right.
If I'm reading correctly you're Gzip-encoding each chunk. But that's not how it's meant to happen.
Compression precedes the chunking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #25, (only the second commit is relevant) and should add support for
gzipcompression withchunked(I haven't tested it)