Skip to content

fix: external translate-c does not need a zig toolchain #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aherrmann merged 1 commit into from
May 9, 2026
Merged

fix: external translate-c does not need a zig toolchain #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions zig/private/common/translate_c.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def _builtin_translate_c(*, ctx, zigtoolchaininfo, global_args, compilation_cont

return zig_out, []

def _external_translate_c(*, ctx, zigtoolchaininfo, translatectoolchaininfo, compilation_context, output_prefix):
def _external_translate_c(*, ctx, translatectoolchaininfo, compilation_context, output_prefix):
inputs = []
transitive_inputs = [compilation_context.headers]

Expand Down Expand Up @@ -263,12 +263,7 @@ def _external_translate_c(*, ctx, zigtoolchaininfo, translatectoolchaininfo, com
mnemonic = "ZigTranslateC",
progress_message = "zig translate-c %{label}",
execution_requirements = {tag: "" for tag in ctx.attr.tags},
env = {
"ZIG_GLOBAL_CACHE_DIR": zigtoolchaininfo.zig_cache,
"ZIG_LIB_DIR": zigtoolchaininfo.zig_lib_path,
"ZIG_LOCAL_CACHE_DIR": zigtoolchaininfo.zig_cache,
},
tools = [translatectoolchaininfo.files_to_run] + zigtoolchaininfo.zig_files,
tools = [translatectoolchaininfo.files_to_run],
toolchain = "//zig:toolchain_type",
**actions_run_extra_kwargs
)
Expand Down Expand Up @@ -301,7 +296,6 @@ def zig_translate_c(*, ctx, name, zigtoolchaininfo, global_args, cc_infos, outpu
if translatectoolchaininfo:
zig_out, translate_c_deps = _external_translate_c(
ctx = ctx,
zigtoolchaininfo = zigtoolchaininfo,
translatectoolchaininfo = translatectoolchaininfo,
compilation_context = compilation_context,
output_prefix = output_prefix,
Expand Down
Loading