Move build to PEP 517 #34
Open
+50
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
force-pushed
the
pep517
branch
2 times, most recently
from
4b21785 to
ae9eaee
Compare
Contributor
Author
|
For dynamic versioning there is https://pypi.org/project/git-versioner/ |
Contributor
Author
|
@ahebrank Would you mind having a look? |
Owner
|
Please provide reasoning for the change and context in the MR description. This is a VERY old project so I'm not sure I see the benefit here. |
Contributor
Author
Will do, but VERY old does not mean broken or unusable. It works perfectly well. |
This update ensures compatibility with modern tools like pip, build, and pyproject.toml, and helps avoid deprecation issues with legacy setup.py-based builds. It also improves reproducibility and security by enabling isolated builds, which is increasingly important for CI/CD pipelines and downstream packaging systems.
Contributor
Author
Done. The source can flawlessly build on 3.12+ without legacy tools. |
Contributor
Author
|
@ahebrank Did you get a chance to reevaluate my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures compatibility with modern tools like pip, build, and
pyproject.toml, and helps avoid deprecation issues with legacy setup.py-based
builds. It also improves reproducibility and security by enabling isolated
builds, which is increasingly important for CI/CD pipelines and downstream
packaging systems.