fix(extensions): resolve AutoContextMemory API role compliance#998
Open
jujn wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(extensions): resolve AutoContextMemory API role compliance#998jujn wants to merge 1 commit intoagentscope-ai:mainfrom
jujn wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes AutoContextMemory’s “current round” compression output to comply with chat API role requirements by ensuring the generated compressed summary message is treated as a USER message (not an ASSISTANT message).
Changes:
- Update current-round compressed summary message construction to use
MsgRole.USERandname="user". - Add a regression test asserting the compressed current-round summary message role/name are USER/user.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agentscope-extensions/agentscope-extensions-autocontext-memory/src/main/java/io/agentscope/core/memory/autocontext/AutoContextMemory.java | Changes the current-round compressed summary message role/name to USER/user for API compliance. |
| agentscope-extensions/agentscope-extensions-autocontext-memory/src/test/java/io/agentscope/core/memory/autocontext/AutoContextMemoryTest.java | Adds a test that verifies the compressed current-round summary message is emitted with USER role and name="user". |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #997
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)