fix(tool): preserve tool id and name in timeout error results#1431
Open
Sparkle6979 wants to merge 2 commits into
Open
fix(tool): preserve tool id and name in timeout error results#1431Sparkle6979 wants to merge 2 commits into
Sparkle6979 wants to merge 2 commits into
Conversation
When a tool call times out in executeWithInfrastructure(), the error path via onErrorResume creates a ToolResultBlock.error() without calling withIdAndName(). The normal path goes through .map() which sets id/name, but timeout errors bypass .map(). This causes PostActingEvent.getToolResult() to return a ToolResultBlock with null id and name, while getToolResultMsg() has the correct values (rebuilt from ToolUseBlock by ToolResultMessageBuilder). Fix by chaining .withIdAndName() in the onErrorResume handler. Fixes agentscope-ai#1389
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tool call times out in
executeWithInfrastructure(), the error path viaonErrorResumecreates aToolResultBlock.error()without callingwithIdAndName(). The normal path goes through.map()which correctly sets id/name, but timeout errors bypass.map().This causes
PostActingEvent.getToolResult()to return aToolResultBlockwith null id and name, whilegetToolResultMsg()has the correct values (rebuilt fromToolUseBlockbyToolResultMessageBuilder).Fix: chain
.withIdAndName(toolCall.getId(), toolCall.getName())in theonErrorResumehandler.Fixes #1389