Skip to content

refactor(examples): remove Lombok from graceful-shutdown module#1410

Open
YunKuiLu wants to merge 1 commit into
agentscope-ai:mainfrom
YunKuiLu:remove-lombok
Open

refactor(examples): remove Lombok from graceful-shutdown module#1410
YunKuiLu wants to merge 1 commit into
agentscope-ai:mainfrom
YunKuiLu:remove-lombok

Conversation

@YunKuiLu
Copy link
Copy Markdown

Summary

  • Remove lombok dependency from agentscope-examples/graceful-shutdown/pom.xml
  • Replace @Slf4j annotation with manual LoggerFactory.getLogger() declaration in AgentService.java

Motivation

The graceful-shutdown example module declared a dependency on Lombok (org.projectlombok:lombok), which caused compilation failure for projects that do not have Lombok configured in their IDE or build environment (no annotation processor setup). This created an unnecessary barrier for users trying to build the examples.

Verification

  • Module contains zero remaining Lombok references
  • log variable name unchanged — all 4 call sites (log.info, log.warn) work without modification
  • SLF4J is already available as a transitive dependency via spring-boot-starter-web

Replace @slf4j annotation with manual Logger declaration and remove
Lombok dependency from pom.xml.
@YunKuiLu YunKuiLu requested a review from a team May 16, 2026 10:33
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 16, 2026

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants