fix: check matching IDs before skipping pending tool recovery#1407
Open
Aaromalpm wants to merge 2 commits into
Open
fix: check matching IDs before skipping pending tool recovery#1407Aaromalpm wants to merge 2 commits into
Aaromalpm wants to merge 2 commits into
Conversation
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1406
Problem
The hook was skipping auto-recovery whenever any
ToolResultBlockexistedin the input messages, even if those results were unrelated to the pending
tool call IDs.
Fix
Instead of checking if any
ToolResultBlockexists, now we extract the IDsfrom the input
ToolResultBlocks and check if they actually match thepending tool call IDs. Recovery is only skipped when there is a genuine match.
4. Make sure the base repository is agentscope-ai/agentscope-java and base branch is main
5. Click Create pull request