Skip to content

feat(model): Support DashScope model preserve_thinking option#1112

Open
guanxuc wants to merge 2 commits into
agentscope-ai:mainfrom
guanxuc:dashscope-preserve_thinking
Open

feat(model): Support DashScope model preserve_thinking option#1112
guanxuc wants to merge 2 commits into
agentscope-ai:mainfrom
guanxuc:dashscope-preserve_thinking

Conversation

@guanxuc
Copy link
Copy Markdown
Contributor

@guanxuc guanxuc commented Apr 2, 2026

AgentScope-Java Version

1.0.12

Description

  • Support DashScope Model preserve_thinking option.
  • Delete deprecated method for MilvusStore.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team April 2, 2026 16:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...a/io/agentscope/core/model/DashScopeChatModel.java 75.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@LearningGp
Copy link
Copy Markdown
Collaborator

image

@guanxuc guanxuc force-pushed the dashscope-preserve_thinking branch from 81fc835 to e331025 Compare May 18, 2026 01:36
@guanxuc guanxuc force-pushed the dashscope-preserve_thinking branch from e331025 to 249ac91 Compare May 18, 2026 02:04
@guanxuc
Copy link
Copy Markdown
Contributor Author

guanxuc commented May 18, 2026

@LearningGp I have merged main branch and resolved the conflicts, PTAL when you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants