refactor: conditionally log missing credentials based on policy instead of always logging a warning#333
Merged
Conversation
…ad of always logging a warning
manojbajaj95
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust proxy logging so missing credentials only log as a warning when the proxy is denying the request. In allow mode, the proxy now logs an informational passthrough message instead.
Motivation and Context
Issue
#293reports that when GitHub credentials are not present, Authsome logs the situation too harshly even though passthrough is intentional. This change makes the log level match the actual behavior:infofor allowed passthrough,warningfor denied requests.Fixes #293.
How Has This Been Tested?
Ran:
uv run pytestAlso added a focused regression test in
tests/proxy/test_proxy.pyfor the no-credentials passthrough path.Types of changes
Checklist: