Skip to content

Support effort levels#464

Draft
benbrandt wants to merge 1 commit intomainfrom
support-effort-levels
Draft

Support effort levels#464
benbrandt wants to merge 1 commit intomainfrom
support-effort-levels

Conversation

@benbrandt
Copy link
Copy Markdown
Member

@benbrandt benbrandt commented Mar 25, 2026

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 25, 2026
@benbrandt
Copy link
Copy Markdown
Member Author

benbrandt commented Mar 25, 2026

It's wired up... but I am not convinced it is working on my plan... Feels like we need some other check to know if the user can set this or not...

@benbrandt benbrandt marked this pull request as draft March 26, 2026 10:34
@jsgrrchg jsgrrchg mentioned this pull request Apr 7, 2026
Closed
@kayakyakr
Copy link
Copy Markdown

kayakyakr commented Apr 18, 2026

This seems to be unnecessary now as 0.29.2, at least, comes with functional effor level selection.

@martenlienen
Copy link
Copy Markdown

martenlienen commented Apr 19, 2026

Can you describe how? According to the changelog, 0.29.2 only has a bugfix that seems unrelated.

@kayakyakr
Copy link
Copy Markdown

kayakyakr commented Apr 19, 2026

Can you describe how? According to the changelog, 0.29.2 only has a bugfix that seems unrelated.

My bad. It looks like it was something that @rohan-patra added in his 0.27.0 update. I'm running my own customized fork and I must have gotten confused with which codebase brought in which code.

It might be worth taking a look as his implementation, seeing how it differs, the effort_level selector code in his branch is clean:
rohan-patra@151a991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benbrandt @kayakyakr @martenlienen