Add Cloud Monitoring dashboard for ATE gRPC server metrics#130
Merged
Conversation
Haven Xia (HavenXia)
force-pushed
the
metrics
branch
2 times, most recently
from
b4c7bf0 to
149905f
Compare
Haven Xia (HavenXia)
added
kind/docs
Haven Xia (HavenXia)
force-pushed
the
metrics
branch
from
149905f to
15adebe
Compare
| @@ -0,0 +1,158 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Does this only work on GCP? We might want to refactor at some point to split them.
Collaborator
Author
There was a problem hiding this comment.
Yes for now, we need to configure all dashboards we add for Cloud Monitoring also to OSS (e.g. Grafana).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Google Cloud Monitoring dashboard for the otelgrpc
rpc.server.call.durationhistogram emitted by ateapi and atelet: per-method p50/p95/p99 latency, request rate, and error rate by gRPC status code (6 dashboards in total).Also adds a setup task (
go run ./cmd/setup --create-monitoring-dashboards, also run by--all) that creates/updates the dashboards inmonitoring/dashboards/idempotently.Dashboards live in monitoring/dashboards/ with a short README.
Example:
Fixes b/518020733.