Merged
Conversation
This was referenced May 2, 2026
philip
pushed a commit
to philip/afdocs
that referenced
this pull request
May 7, 2026
Sitemap entries are commonly published on the bare-host canonical (e.g. https://swift.org/...) even when the served site is www.swift.org. The strict `origin !==` comparison in shouldInclude() and scopeUrls() discarded every such URL, causing afdocs to fall back to single-page sampling and trigger the single-page-sample diagnostic. PR agent-ecosystem#82 already added the right sitemap discovery candidates, so the root sitemap was being fetched — its URLs were just being filtered out before they could be used. Fix: introduce isSameOriginIgnoringWww() (built on the existing isWwwVariant helper) and use it in both filter sites. Adds tests covering both directions of www mismatch and a regression test confirming truly cross-host URLs are still rejected. Fixes agent-ecosystem#83.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #81; sitemap discovery fallbacks were missing
sitemap-index.xmlandsitemap_index.xmlvariants used in real docs sites. Adding them here to resolve this issue.Also noted many slow tests related to unlocked URLs attempting real network calls and timing out, so correctly applying mocks in those cases here.