Open
Conversation
Collaborator
|
My first thoughts (on waking up this morning) are:
Out of interest, as well as the time gained back, is it easy to measure the comparative memory footprint of the two versions? |
Member
Author
I don't know how I could do that I'm afraid |
Member
|
You can throw in |
Member
Author
|
without-K: cubical-compatible: |
Collaborator
|
OK, IIUC, the change takes 75% of time, and roughly the same for memory as well. Sold! |
JacquesCarette
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very rough benchmarks (running
time make testaftergit clean -fxd:--without-K:--cubical-compatibleSo,
--without-Ktakes about three quarters the time of--cubical-compatible.I don't think we have a clear use case for using
--cubical-compatible. If it turns out there is one, we should put some effort into fixing the unsupported index matches, warnings for which we're currently hiding.