Memory Allocation Fixes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenridd
commented
Oct 16, 2025
haydenridd
commented
- Fixed undefined behavior with calling memcpy on nullptr
- Fixed memory leak in aflib
- Fixed memory leak in aflib
haydenridd
commented
Oct 16, 2025
|
|
||
| void af_command_get_value(af_command_t *af_command, uint8_t *value) { | ||
| memcpy(value, af_command->value, af_command->value_len); | ||
| if(af_command->value_len > 0) { |
Author
There was a problem hiding this comment.
If this guard isn't here, memcpy regularly gets called with a nullptr for af_command->value. Always with a af_command->value_len = 0, which is why this doesn't cause worse behavior. Technically Undefined Behavior though.
haydenridd
commented
Oct 16, 2025
| } | ||
|
|
||
| void af_lib_destroy(af_lib_t* af_lib) { | ||
| queue_free(); |
Author
There was a problem hiding this comment.
Running aflib on Linux with some memory leak detectors caught this one. Memory related to the attribute queue is never freed on af_lib_destroy, this fixes that.
haydenridd
commented
Oct 16, 2025
| */ | ||
| af_lib_error_t af_lib_get_attribute(af_lib_t *af_lib, const uint16_t attr_id) { | ||
| uint8_t dummy; // This value isn't actually used. | ||
| uint8_t dummy = 0; // This value isn't actually used. |
Author
There was a problem hiding this comment.
It may not be used, but we still probably shouldn't pass around pointers to uninitialized memory :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.