Fix Studio Team member route context#601
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dev #601 +/- ##
==========================================
- Coverage 72.02% 72.01% -0.01%
==========================================
Files 1255 1255
Lines 90723 90723
Branches 11877 11877
==========================================
- Hits 65343 65337 -6
- Misses 20699 20703 +4
- Partials 4681 4683 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
focusso asset deep links do not replace the Team member context.teamIdthrough Studio bind/invoke/member switching and return links.Why
Issue #585 needs Studio links to stay scoped to the selected Team and member. Without this, users can enter Studio from a Team surface and lose the Team/member context, which makes the route look correct at the Scope level but wrong at the product level.
Impact
Validation
npm --prefix apps/aevatar-console-web run tscnpm --prefix apps/aevatar-console-web run jest -- --selectProjects jsdom --runTestsByPath src/pages/teams/home.test.tsx src/pages/teams/detail.test.tsx src/pages/studio/index.test.tsx src/shared/studio/navigation.test.ts --runInBandnpm --prefix apps/aevatar-console-web run jest -- --runTestsByPath src/shared/studio/navigation.test.ts --runInBandnpm --prefix apps/aevatar-console-web run jest -- --selectProjects jsdom --runTestsByPath src/pages/teams/home.test.tsx src/pages/teams/detail.test.tsx --runInBandgit diff --check/design-reviewbrowser screenshot verification for Team home/detail mobile layoutCloses #585