This repository was archived by the owner on Mar 31, 2026. It is now read-only.
Migrate PR #164: feat: check cycle error#1393
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## dev #1393 +/- ##
==========================================
+ Coverage 39.88% 39.90% +0.01%
==========================================
Files 637 637
Lines 25784 25824 +40
Branches 2416 2424 +8
==========================================
+ Hits 10284 10304 +20
- Misses 14897 14920 +23
+ Partials 603 600 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
chao0kang
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates aevatarAI/aevatar-gagents#164 to the aevatar-station repository.
Original PR Details
Changes Made
This PR adds cycle detection to the WorkflowViewGAgent to prevent circular dependencies in workflow graphs. The implementation includes:
Files Modified
gagents/src/Aevatar.GAgents.GroupChat/GAgent/Coordinator/WorkflowView/WorkflowViewGAgent.cs- Added HasCycle method and cycle validation in PerformConfigAsyncgagents/test/Aevatar.GAgents.GroupChat.Test/Tests/WorkFlowViewTest.cs- Added two unit tests to verify cycle detection works correctlyTesting
WorkflowViewTest_Should_Throw_When_SelfLoopExists- Tests self-loop detectionWorkflowViewTest_Should_Throw_When_CycleExists- Tests general cycle detectionMigration Details
git cherry-pick -X subtree=gagents f2c47e3cgagents/subdirectory