Make the v3 topic modeling workflow backend-agnostic and add tomotopy support#226
Open
sldyns wants to merge 1 commit intoaertslab:pycistopic_v3from
Open
Make the v3 topic modeling workflow backend-agnostic and add tomotopy support#226sldyns wants to merge 1 commit intoaertslab:pycistopic_v3from
sldyns wants to merge 1 commit intoaertslab:pycistopic_v3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the current
pycistopic_v3topic-modeling workflow so that v3 artifacts are backend-agnostic instead of being tied to Mallet-specific readers and filenames, and adds atomotopyLDA backend that writes the same artifact bundle.What changed
topic_models.pyTopicModelFilenamesto centralize the v3 artifact layoutload_topic_model_backendLDATomotopyto train directly from the binary accessibility matrix and write the standard v3 outputsLDAMalletto implement the same backend interface and emit the same artifact bundletopic_modelingCLI to use a sharedrunentry point with--backend {mallet,tomotopy}tomotopyto run directly from the matrix plus barcode/region inputscreate_anndata, model-stat calculation, plotting, and topic binarization to load outputs through the backend abstraction instead of assuming Mallet-only artifactsalphavalues fromtomotopytomotopy>=0.14.0as a dependency