Fix file extensions to be inferred from output format #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When downloading files from a bulk export, the extension is now derived from the output format rather than using a hardcoded extension. This ensures Parquet files get .parquet extensions when using application/vnd.apache.parquet format.
Previously, outputExtension was used as a fallback when the format was unrecognised. Now it acts as an explicit override: - If outputExtension is set, use it regardless of format - Otherwise, infer extension from outputFormat - Default to "ndjson" for unknown formats
johngrimes
temporarily deployed
to
maven-central
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output file extensions are now derived from the
outputFormatMIME type rather than requiring explicit configuration.Supported formats:
application/fhir+ndjson,application/x-ndjson,ndjson→.ndjsonapplication/vnd.apache.parquet,parquet→.parquet.ndjson(default)The
outputExtensionparameter is now optional. When set, it overrides the inferred extension; when omitted, the extension is inferred from the format.