-
Notifications
You must be signed in to change notification settings - Fork 9
Let admins invalidate the password of selected users #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Marc-Andrieu
wants to merge
8
commits into
main
Choose a base branch
from
security/password-invalidation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 84.86% 84.84% -0.03%
==========================================
Files 199 199
Lines 14094 14110 +16
==========================================
+ Hits 11961 11971 +10
- Misses 2133 2139 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0c66557 to
1af98b3
Compare
22 tasks
Marc-Andrieu
added a commit
that referenced
this pull request
Jan 6, 2026
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> Renaming MyECLPay to MyPayment for 2 reasons: - Compatibility with CalypSSO: For #879 I need a change on CalypSSO, but the current latest (2.6.1) breaks Hyperion, hence this refacto is required - Genericity: not hard-coding our school's name in the internal payment solution to make it easier to fork and deploy for other schools <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then #123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] Renaming myeclpay to mypayment to fix CalypSSO compatibility - [x] Refacto for CalypSSO to work - [x] Refactor the displayname for the front-end ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [x] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [x] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [x] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [x] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [x] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
1af98b3 to
2c53461
Compare
Member
Author
|
Missing:
|
Member
Author
|
Back-end of aeecleclair/CalypSSO#189 |
bd1e720 to
0acca2e
Compare
0acca2e to
62ce1ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Let admins to mark a range of users with a stamp to compel them to change their password, effectively making a password change campaign.
This changes in the logic for password modification (no putting the same) and on authorization (authentication should instead lead saying that yes we know it's [probably] you but we don't authorize, you need to change the password)
Changes Made
should_change_passwordinCoreUser, not nullable, default falseshould_change_passwordfor one userDetails
Type of Change
Impact & Scope
Testing
Documentation