chore: bump urllib3 from 2.6.1 to 2.7.0 in the pip group across 1 directory + CI Fixes#185
Conversation
Bumps the pip group with 1 update in the / directory: [urllib3](https://github.com/urllib3/urllib3). Updates `urllib3` from 2.6.1 to 2.6.3 - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.6.1...2.6.3) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.6.3 dependency-type: indirect dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com>
Dependency ReviewThe following issues were found:
License IssuesPipfile.lock
OpenSSF Scorecard
Scanned Files
|
Agent-Logs-Url: https://github.com/advanced-security/policy-as-code/sessions/9e3b338b-9667-45f7-ae6e-aa736651ff32 Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Fixed in commit 563743c. There were two root causes:
|
Done in the latest commit. Two fixes applied:
|
There was a problem hiding this comment.
Pull request overview
Updates the Python dependency lockfile to use urllib3==2.7.0 (addressing the referenced CVEs), but also includes additional changes to workflow/job gating and CLI argument forwarding that are not reflected in the PR description/title.
Changes:
- Bump
urllib3from2.6.1to2.7.0inPipfile.lock(default + develop). - Change
policy-as-codeto forward CLI args using"$@"when invokingpython3 -m ghascompliance. - Skip some GitHub Actions jobs when the PR author is
dependabot[bot].
Show a summary per file
| File | Description |
|---|---|
policy-as-code |
Adjusts argument forwarding to the Python module invocation. |
Pipfile.lock |
Updates locked urllib3 version/hashes to 2.7.0 (and adds index metadata in default). |
.github/workflows/main.yml |
Adds Dependabot-based gating for e2e-tests and action-test jobs. |
.github/workflows/cli.yml |
Adds Dependabot-based gating for the run job. |
Copilot's findings
Comments suppressed due to low confidence (1)
.github/workflows/main.yml:62
- This PR is described as an urllib3 version bump, but this change also skips the action-test job for Dependabot PRs. Please update the PR description/scope accordingly so reviewers can explicitly evaluate the CI/coverage impact of this workflow change.
action-test:
runs-on: ubuntu-latest
if: ${{ github.event.pull_request.user.login != 'dependabot[bot]' }}
needs: run
- Files reviewed: 3/4 changed files
- Comments generated: 3
Bumps the pip group with 1 update in the / directory: urllib3.
Updates
urllib3from 2.6.1 to 2.7.0, fixing two high-severity CVEs present in 2.6.3:Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Workflow changes:
.github/workflows/cli.ymlto skip therunjob if the pull request author is Dependabot, preventing unnecessary runs for automated dependency updates..github/workflows/main.ymlto skip both thee2e-testsandaction-testjobs for Dependabot pull requests, reducing CI resource usage for automated PRs. [1] [2]Script improvements:
policy-as-codescript to correctly pass all arguments to Python by quoting"$@", ensuring arguments with spaces are handled properly.