Skip to content

chore: bump urllib3 from 2.6.1 to 2.7.0 in the pip group across 1 directory + CI Fixes#185

Merged
felickz merged 3 commits into
mainfrom
dependabot/pip/pip-8177a8837a
May 11, 2026
Merged

chore: bump urllib3 from 2.6.1 to 2.7.0 in the pip group across 1 directory + CI Fixes#185
felickz merged 3 commits into
mainfrom
dependabot/pip/pip-8177a8837a

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Feb 10, 2026

Bumps the pip group with 1 update in the / directory: urllib3.

Updates urllib3 from 2.6.1 to 2.7.0, fixing two high-severity CVEs present in 2.6.3:


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Workflow changes:

  • Updated .github/workflows/cli.yml to skip the run job if the pull request author is Dependabot, preventing unnecessary runs for automated dependency updates.
  • Updated .github/workflows/main.yml to skip both the e2e-tests and action-test jobs for Dependabot pull requests, reducing CI resource usage for automated PRs. [1] [2]

Script improvements:

  • Modified the policy-as-code script to correctly pass all arguments to Python by quoting "$@", ensuring arguments with spaces are handled properly.

Bumps the pip group with 1 update in the / directory: [urllib3](https://github.com/urllib3/urllib3).


Updates `urllib3` from 2.6.1 to 2.6.3
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.6.1...2.6.3)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.3
  dependency-type: indirect
  dependency-group: pip
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added Dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Feb 10, 2026
@dependabot dependabot Bot requested a review from a team as a code owner February 10, 2026 22:50
@dependabot dependabot Bot requested review from adrienpessu and felickz February 10, 2026 22:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 10, 2026

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

Pipfile.lock

PackageVersionLicenseIssue Type
urllib32.7.0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
pip/urllib3 2.7.0 UnknownUnknown
pip/urllib3 2.7.0 UnknownUnknown

Scanned Files

  • Pipfile.lock

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@copilot fix the failing CI (https://github.com/advanced-security/policy-as-code/actions/runs/21885476597/job/63179134667?pr=185 https://github.com/advanced-security/policy-as-code/actions/runs/218854...

Fixed in commit 563743c. There were two root causes:

  1. policy-as-code bash script had unquoted $@ — bash word-splitting drops empty string arguments, so --github-token "" (empty secret) was passed to Python as just --github-token (no value), causing the argparse "expected one argument" error. Fixed by quoting: "$@".

  2. Integration tests in cli.yml, main.yml (e2e-tests, action-test) all require POLICY_AS_CODE_TESTING_TOKEN, which Dependabot PRs cannot access. Added if: ${{ github.actor != 'dependabot[bot]' }} to skip those jobs for Dependabot. The unit test jobs in main.yml continue to run for Dependabot PRs as they don't need the token.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

@copilot upgrade to 2.7.0 urllib ( fix https://github.com/advanced-security/policy-as-code/actions/runs/24422933319?pr=185) + fix failing CIs https://github.com/advanced-security/policy-as-code/action...

Done in the latest commit. Two fixes applied:

  1. urllib3 upgraded to 2.7.0 in Pipfile.lock (both default and develop sections) — resolves the two high-severity CVEs (GHSA-qccp-gfcp-xxvc and GHSA-mf9v-mfxr-j63j) that caused the dependency-review failure.

  2. Workflow if conditions updated from github.actor != 'dependabot[bot]' to github.event.pull_request.user.login != 'dependabot[bot]' in cli.yml and main.yml — this checks the PR author rather than the run triggering actor, so integration tests are correctly skipped for Dependabot PRs even when a maintainer manually re-runs them.

Copilot AI changed the title chore: bump urllib3 from 2.6.1 to 2.6.3 in the pip group across 1 directory chore: bump urllib3 from 2.6.1 to 2.7.0 in the pip group across 1 directory May 11, 2026
@felickz felickz requested a review from Copilot May 11, 2026 19:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Python dependency lockfile to use urllib3==2.7.0 (addressing the referenced CVEs), but also includes additional changes to workflow/job gating and CLI argument forwarding that are not reflected in the PR description/title.

Changes:

  • Bump urllib3 from 2.6.1 to 2.7.0 in Pipfile.lock (default + develop).
  • Change policy-as-code to forward CLI args using "$@" when invoking python3 -m ghascompliance.
  • Skip some GitHub Actions jobs when the PR author is dependabot[bot].
Show a summary per file
File Description
policy-as-code Adjusts argument forwarding to the Python module invocation.
Pipfile.lock Updates locked urllib3 version/hashes to 2.7.0 (and adds index metadata in default).
.github/workflows/main.yml Adds Dependabot-based gating for e2e-tests and action-test jobs.
.github/workflows/cli.yml Adds Dependabot-based gating for the run job.

Copilot's findings

Comments suppressed due to low confidence (1)

.github/workflows/main.yml:62

  • This PR is described as an urllib3 version bump, but this change also skips the action-test job for Dependabot PRs. Please update the PR description/scope accordingly so reviewers can explicitly evaluate the CI/coverage impact of this workflow change.
  action-test:
    runs-on: ubuntu-latest
    if: ${{ github.event.pull_request.user.login != 'dependabot[bot]' }}
    needs: run 
  • Files reviewed: 3/4 changed files
  • Comments generated: 3

Comment thread policy-as-code
Comment thread .github/workflows/main.yml
Comment thread .github/workflows/cli.yml
Copy link
Copy Markdown
Contributor

@felickz felickz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:dependabot: 👍

@felickz felickz changed the title chore: bump urllib3 from 2.6.1 to 2.7.0 in the pip group across 1 directory chore: bump urllib3 from 2.6.1 to 2.7.0 in the pip group across 1 directory + CI Fixes May 11, 2026
@felickz felickz merged commit c66af84 into main May 11, 2026
19 checks passed
@felickz felickz deleted the dependabot/pip/pip-8177a8837a branch May 11, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants