Client side request forgery from jQuery.sap.getUriParameters()#312
Open
Client side request forgery from jQuery.sap.getUriParameters()#312
jQuery.sap.getUriParameters()#312Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SAP UI5 source modeling to treat URL query parameters as browser-derived inputs and adds regression tests ensuring request-forgery alerts are classified as client-side rather than server-side.
Changes:
- Model
UI5URIParameters.get/getAllreturn values asbrowser-url-querysources in the UI5 data extension. - Add UI5 test cases asserting
ClientSideRequestForgeryfires (andRequestForgerydoes not) for URL-query-controlled XHR. - Bump
codeql/javascript-all(and internal pack dependencies) to align packs/tests with the new modeling.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/heuristic-models/tests/qlpack.yml | Bump JS pack dependency versions used by heuristic-model tests. |
| javascript/heuristic-models/ext/qlpack.yml | Update extension target codeql/javascript-all version range. |
| javascript/frameworks/xsjs/test/qlpack.yml | Align XSJS tests with updated codeql/javascript-all and internal pack versions. |
| javascript/frameworks/xsjs/src/qlpack.yml | Align XSJS queries pack dependencies to updated versions. |
| javascript/frameworks/xsjs/lib/qlpack.yml | Bump codeql/javascript-all dependency for XSJS “all” pack. |
| javascript/frameworks/xsjs/ext/qlpack.yml | Update extension target codeql/javascript-all version range for XSJS models. |
| javascript/frameworks/ui5/test/queries/RequestForgery/test.js | New minimal repro: URL query param flows into XHR request URL. |
| javascript/frameworks/ui5/test/queries/RequestForgery/RequestForgery.qlref | New regression target for server-side RequestForgery query (expecting no result). |
| javascript/frameworks/ui5/test/queries/RequestForgery/RequestForgery.expected | Expected output asserting no RequestForgery finding for browser URL-query input. |
| javascript/frameworks/ui5/test/queries/RequestForgery/ClientSideRequestForgery.qlref | New regression target for ClientSideRequestForgery query. |
| javascript/frameworks/ui5/test/queries/RequestForgery/ClientSideRequestForgery.expected | Expected output asserting a client-side request-forgery finding. |
| javascript/frameworks/ui5/test/qlpack.yml | Align UI5 tests with updated codeql/javascript-all and internal pack versions. |
| javascript/frameworks/ui5/test/models/source/sourceTest.expected | Update expected source-kind classification for UI5 URL parameter sources. |
| javascript/frameworks/ui5/src/qlpack.yml | Align UI5 queries pack dependencies to updated versions. |
| javascript/frameworks/ui5/lib/qlpack.yml | Bump codeql/javascript-all dependency for UI5 “all” pack. |
| javascript/frameworks/ui5/ext/ui5.model.yml | Change UI5 URI parameter sources to browser-url-query. |
| javascript/frameworks/ui5/ext/qlpack.yml | Update extension target codeql/javascript-all version range for UI5 models. |
| javascript/frameworks/ui5-webcomponents/test/qlpack.yml | Align UI5-webcomponents tests with updated codeql/javascript-all and internal pack versions. |
| javascript/frameworks/cap/test/qlpack.yml | Align CAP tests with updated codeql/javascript-all and internal pack versions. |
| javascript/frameworks/cap/src/qlpack.yml | Align CAP queries pack dependencies to updated versions. |
| javascript/frameworks/cap/lib/qlpack.yml | Bump codeql/javascript-all dependency for CAP “all” pack. |
| javascript/frameworks/cap/ext/qlpack.yml | Update extension target codeql/javascript-all version range for CAP models. |
jQuery.sap.getUriParameters().get()
jQuery.sap.getUriParameters().get()jQuery.sap.getUriParameters()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browser-url-query, the alert is now correctly classified as "ClientSideRequestForgery" and not as "RequestForgery"2.25.0