Add a BlockId module that is language agnostic, plus cpp impl.#17
Open
MichaelRFairhurst wants to merge 2 commits intomainfrom
Open
Add a BlockId module that is language agnostic, plus cpp impl.#17MichaelRFairhurst wants to merge 2 commits intomainfrom
BlockId module that is language agnostic, plus cpp impl.#17MichaelRFairhurst wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a language-agnostic BlockId module for assigning unique IDs to basic blocks and control flow nodes in control flow graphs, along with a C++ implementation.
- Adds a generic
BlockIdmodule with sophisticated cycle-aware ID assignment algorithm - Implements C++-specific binding through
CppBlockIdConfig - Includes comprehensive test coverage for various control flow patterns
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/qtil/cfg/BlockId.qll | Core language-agnostic module implementing the block ID assignment algorithm |
| cpp/src/qtil/cpp/cfg/BlockId.qll | C++ language binding for the BlockId module |
| test/qtil/cfg/BlockIdTest.ql | Language-agnostic test suite with mock control flow structures |
| cpp/test/qtil/cpp/cfg/BlockIdTest.ql | Simple C++ integration test |
| cpp/test/qtil/cpp/cfg/test.cpp | C++ test code with various control flow patterns |
| cpp/src/qtil/Cpp.qll | Updates module exports to include new BlockId functionality |
| README.md | Documentation update describing the new BlockId feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.