docs: fix makeUsingStub example to use join(import.meta.dirname)#14
Open
matisbag wants to merge 2 commits intoadonisjs:mainfrom
Open
docs: fix makeUsingStub example to use join(import.meta.dirname)#14matisbag wants to merge 2 commits intoadonisjs:mainfrom
matisbag wants to merge 2 commits intoadonisjs:mainfrom
Conversation
matisbag
force-pushed
the
fix/make-using-stub-url-type
branch
from
a6e7d30 to
5d87202
Compare
matisbag
force-pushed
the
fix/make-using-stub-url-type
branch
from
5d87202 to
09552f2
Compare
thetutlage
reviewed
Mar 19, 2026
…ame for STUBS_ROOT
matisbag
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
The
makeUsingStubmethod expects astringas its first argument (as per its type definition), but the scaffolding example passes aURLobject directly.This causes a TypeScript type error.