Skip to content

fix: Router should be Macroable#119

Merged
thetutlage merged 1 commit into
adonisjs:9.xfrom
ThisIsMissEm:fix/router-no-longer-macroable
May 27, 2026
Merged

fix: Router should be Macroable#119
thetutlage merged 1 commit into
adonisjs:9.xfrom
ThisIsMissEm:fix/router-no-longer-macroable

Conversation

@ThisIsMissEm
Copy link
Copy Markdown
Contributor

🔗 Linked issue

#80 — This was fixed in 7.x, but was broken during the refactor for 8.x which removed LookupStore.

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This change aligns the Router with the published documentation for 8.x: https://docs.adonisjs.com/guides/basics/routing#router

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have added tests to prevent further ocurrences of this regression.

@thetutlage thetutlage merged commit c8da134 into adonisjs:9.x May 27, 2026
4 checks passed
@thetutlage
Copy link
Copy Markdown
Member

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants