Skip to content

ValidatorExtractor: Support tryValidate#93

Merged
thetutlage merged 2 commits intoadonisjs:8.xfrom
jeppester:try-validate
Mar 19, 2026
Merged

ValidatorExtractor: Support tryValidate#93
thetutlage merged 2 commits intoadonisjs:8.xfrom
jeppester:try-validate

Conversation

@jeppester
Copy link
Contributor

🔗 Linked issue

Not sure if I need to create a pro-forma issue for this?

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This change lets codegen extract controller action validators that use "tryValidate".
For end users this means the tuyau's will be able to understand the body type for such controller actions.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

Looks good! Could we add another test that uses request.tryValidateUsing without the ctx?

@jeppester
Copy link
Contributor Author

jeppester commented Mar 19, 2026

Looks good! Could we add another test that uses request.tryValidateUsing without the ctx?

Sure. All the other cases were not tested, so I was a bit unsure about how many tests to add

@jeppester
Copy link
Contributor Author

@thetutlage Better?

@thetutlage
Copy link
Member

Yup, thanks 🙏

@thetutlage thetutlage merged commit 1a48888 into adonisjs:8.x Mar 19, 2026
4 checks passed
@jeppester jeppester deleted the try-validate branch March 19, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants