Skip to content

Exclude tmp, storage, and build directories from file watcher#91

Merged
thetutlage merged 4 commits intoadonisjs:8.xfrom
guoyunhe:ignore-folders
Mar 13, 2026
Merged

Exclude tmp, storage, and build directories from file watcher#91
thetutlage merged 4 commits intoadonisjs:8.xfrom
guoyunhe:ignore-folders

Conversation

@guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Mar 8, 2026

🔗 Linked issue

adonisjs/core#5071

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copilot AI and others added 4 commits March 8, 2026 11:36
Co-authored-by: guoyunhe <5836790+guoyunhe@users.noreply.github.com>
Co-authored-by: guoyunhe <5836790+guoyunhe@users.noreply.github.com>
Exclude `tmp`, `storage`, and `build` directories from file watcher
@ThisIsMissEm
Copy link

This looks reasonable to me, I think.

@thetutlage thetutlage merged commit 3aebb1e into adonisjs:8.x Mar 13, 2026
1 of 4 checks passed
@thetutlage
Copy link
Member

Merged, since the change is harmless. But, I am still wondering how these files are watched, since we rely on Tsconfig includes and only watch files .ts files that are part of the includes

@guoyunhe guoyunhe deleted the ignore-folders branch March 13, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants