fix: persist site config via setConfig after disableImport#240
Open
prithipalpatwal wants to merge 1 commit intomainfrom
Open
fix: persist site config via setConfig after disableImport#240prithipalpatwal wants to merge 1 commit intomainfrom
prithipalpatwal wants to merge 1 commit intomainfrom
Conversation
…sableImport Site save tracks updates through setters; mutating getConfig() alone did not reliably persist import changes. Mirror brand-profile by calling setConfig(Config.toDynamoItem(siteConfig)) before save. Tests mock Config.toDynamoItem and assert setConfig on success paths, and that setConfig is skipped when the site is not found or lookup fails. Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site save tracks updates through setters; mutating getConfig() alone did not reliably persist import changes. Calling setConfig(Config.toDynamoItem(siteConfig)) before save.
Tests mock Config.toDynamoItem and assert setConfig on success paths, and that setConfig is skipped when the site is not found or lookup fails.
Made-with: Cursor
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!