feat(mac): add MacGiverClient and facsWrapper for FACS integration (Phase 1, steps 2–3)#1600
Draft
ravverma wants to merge 7 commits into
Draft
feat(mac): add MacGiverClient and facsWrapper for FACS integration (Phase 1, steps 2–3)#1600ravverma wants to merge 7 commits into
ravverma wants to merge 7 commits into
Conversation
…hase 1, steps 2–3) - Add spacecat-shared-mac-giver-client package with MacGiverClient (getPermissions + checkPermission via POST /api/facs/permissions/check) and macGiverClientWrapper; defaults MACGIVER_BASE_URL to localhost:8080 - Add AuthInfo.getFacsPermissions() and hasFacsPermission() to http-utils - Add facsWrapper to http-utils: enforces FACS permissions per route with internal-identity bypass, internal-org bypass, LD feature-flag gate, deny-by-default for unmapped routes, and x-product header composition - Export FF_MAC_FACS_PERMISSIONS and X_PRODUCT_HEADER from constants Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This PR will trigger a minor release when merged. |
… with current guard message Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ACS_EXCEPTION_INTERNAL_ORGS
- FF_MAC_FACS_PERMISSIONS is now a map from uppercased product code to flag key
(e.g. { LLMO: 'FT_LLMO-3026' }); products without an entry bypass FACS
- Wrapper resolves x-product header first, looks up the per-product flag, and
bypasses (without calling LD) when no flag is configured for the product
- Rename internal-org bypass env var INTERNAL_IMS_ORG_IDS to FACS_EXCEPTION_INTERNAL_ORGS
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ervice token Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!