Conversation
|
This PR will trigger a patch release when merged. |
nit23uec
reviewed
Mar 19, 2026
| const DEFAULT_EXPERIMENT_PLATFORMS = ['chatgpt_free', 'perplexity']; | ||
| const PRE_PHASE_CRON_EXPRESSION = '0 * * * *'; | ||
| const POST_PHASE_CRON_EXPRESSION = '0 0 * * *'; | ||
| const PRE_PHASE_EXPIRY_MS = 10 * 60 * 60 * 1000; // 10 hours |
Contributor
There was a problem hiding this comment.
14 hours - to make sure we have 14 runs each for pre and post phase.
nit23uec
reviewed
Mar 19, 2026
| submitScrapeJob(params: ScrapeJobParams): Promise<DrsJobResult>; | ||
| lookupScrapeResults(params: ScrapeLookupParams): Promise<ScrapeLookupResponse | null>; | ||
| triggerBrandDetection(siteId: string, options?: BrandDetectionOptions): Promise<Record<string, unknown> | null>; | ||
| submitExperiment(params: SubmitExperimentParams): Promise<ExperimentSubmitResult>; |
Contributor
There was a problem hiding this comment.
submitExperiment and getExperimentStatus are not required now
nit23uec
reviewed
Mar 19, 2026
| DEPLOYED: 'deployed', | ||
| POST_ANALYSIS_SUBMITTED: 'post_analysis_submitted', | ||
| POST_ANALYSIS_DONE: 'post_analysis_done', | ||
| FAILED: 'failed', |
Contributor
There was a problem hiding this comment.
what does failed mean here?
we should also have pre analysis failed
nit23uec
reviewed
Mar 19, 2026
|
|
||
| /** | ||
| * Creates an experiment schedule in DRS and optionally triggers it immediately. | ||
| * Uses the schedules API instead of legacy experiments API. |
Contributor
There was a problem hiding this comment.
there is no legacy experiments API
nit23uec
reviewed
Mar 19, 2026
| throw new Error('scheduleId is required'); | ||
| } | ||
|
|
||
| this.log.info('Getting DRS schedule status', { siteId, scheduleId }); |
Contributor
There was a problem hiding this comment.
this also requires ?include_jobs=true query param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!