Skip to content

fix: clone functionality to include submodules #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmaurya929 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clone functionality to include submodules #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/spacecat-shared-cloud-manager-client/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ export default class CloudManagerClient {
this.log.info(`Cloning CM repository: program=${programId}, repo=${repositoryId}, type=${repoType}`);

const args = await this.#buildAuthGitArgs('clone', programId, repositoryId, { imsOrgId, repoType, repoUrl });
this.#execGit([...args, clonePath]);
this.#execGit([...args, '--recurse-submodules', clonePath]);
this.log.info(`Repository cloned to ${clonePath}`);
this.#logTmpDiskUsage('clone');

Expand Down
13 changes: 13 additions & 0 deletions packages/spacecat-shared-cloud-manager-client/test/cloud-manager-client.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,19 @@ describe('CloudManagerClient', () => {
expect(cloneArgsStr).to.not.include('Bearer');
});

it('includes --recurse-submodules in the clone arguments', async () => {
const client = CloudManagerClient.createFrom(createContext());

await client.clone(
TEST_PROGRAM_ID,
TEST_REPO_ID,
{ imsOrgId: TEST_IMS_ORG_ID },
);

const gitArgs = getGitArgs(execFileSyncStub.firstCall);
expect(gitArgs).to.include('--recurse-submodules');
});

it('throws when standard credentials not found for programId', async () => {
const client = CloudManagerClient.createFrom(
createContext({ CM_STANDARD_REPO_CREDENTIALS: TEST_STANDARD_CREDENTIALS }),
Expand Down