feat: Adding a slack command for detecting CDN for customers#1978
Merged
jsanchez07 merged 17 commits intomainfrom Mar 31, 2026
Merged
feat: Adding a slack command for detecting CDN for customers#1978jsanchez07 merged 17 commits intomainfrom
jsanchez07 merged 17 commits intomainfrom
Conversation
|
This PR will trigger a minor release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jkf276
approved these changes
Mar 19, 2026
mikeweis
reviewed
Mar 20, 2026
mikeweis
reviewed
Mar 20, 2026
mikeweis
reviewed
Mar 20, 2026
mikeweis
approved these changes
Mar 20, 2026
Contributor
mikeweis
left a comment
mikeweis
left a comment
There was a problem hiding this comment.
I did leave some comments to consider on the Slack message back to the user, but everything looks good to me 👍
Refactor Slack detect-cdn command to use a shared queueDetectCdnAudit utility, and hook that utility into onboardSingleSite so every newly onboarded site automatically gets CDN detection queued.
jkf276
reviewed
Mar 27, 2026
|
|
||
| // Configure redirectsmode and redirectssource | ||
| // check for authoringType, deliveryType, environmentID, and programID | ||
| // skip update-redirects if invalid |
Contributor
There was a problem hiding this comment.
the purpose of the pre check in onboarding is to allow for graceful skip if the site is not valid for update-redirect. The new function will result in a hard stop if the types or ID are invalid
…missing programId/environmentId Instead of returning hard errors when a site lacks AEM CS identifiers, queueDeliveryConfigWriter now logs a soft skip and proceeds with CDN-only detection. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…spacecat-api-service into SITES-41613-cdn-detection
jkf276
approved these changes
Mar 31, 2026
solaris007
pushed a commit
that referenced
this pull request
Mar 31, 2026
# [1.392.0](v1.391.0...v1.392.0) (2026-03-31) ### Features * Adding a slack command for detecting CDN for customers ([#1978](#1978)) ([6ca33f3](6ca33f3))
Member
|
🎉 This PR is included in version 1.392.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SITES-41613
This PR adds the detect-cdn Slack command so users can trigger CDN detection for a URL from Slack; the API forwards the command to the audit worker via SQS. No REST API or OpenAPI changes.