Skip to content

fix: apply WHCM S2 TableView text color#9589

Open
LFDanLu wants to merge 1 commit intomainfrom
hcm_s2_table
Open

fix: apply WHCM S2 TableView text color#9589
LFDanLu wants to merge 1 commit intomainfrom
hcm_s2_table

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Feb 3, 2026

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test S2 TableView in WHCM, make sure the text color looks correct (shouldn't be a faded gray). Should be covered by https://www.chromatic.com/build?appId=651b502f6b74abaae4ee734c&number=83

🧢 Your Project:

RSP

Comment on lines +958 to +959
isSelected: baseColor('neutral'),
forcedColors: 'ButtonText'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, I noticed that the style of the tableview's disabled row text doesn't change between disabledBehavior all vs selection, can't remember if that was intentional or not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we talked about it yesterday, the text should be changing for that case since you cannot navigate to the row when it's all

@rspbot
Copy link

rspbot commented Feb 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants