Open
Conversation
LFDanLu
commented
Feb 3, 2026
Comment on lines
+958
to
+959
| isSelected: baseColor('neutral'), | ||
| forcedColors: 'ButtonText' |
Member
Author
There was a problem hiding this comment.
As an aside, I noticed that the style of the tableview's disabled row text doesn't change between disabledBehavior all vs selection, can't remember if that was intentional or not
Member
There was a problem hiding this comment.
yeah, we talked about it yesterday, the text should be changing for that case since you cannot navigate to the row when it's all
|
Build successful! 🎉 |
snowystinger
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
Test S2 TableView in WHCM, make sure the text color looks correct (shouldn't be a faded gray). Should be covered by https://www.chromatic.com/build?appId=651b502f6b74abaae4ee734c&number=83
🧢 Your Project:
RSP