Skip to content

fix: roving tabindex in useSelectableCollection for virtualized collections#9582

Merged
snowystinger merged 1 commit intomainfrom
revert-store-scroll-pos-accidental-removal-of-roving-tab-index
Feb 3, 2026
Merged

fix: roving tabindex in useSelectableCollection for virtualized collections#9582
snowystinger merged 1 commit intomainfrom
revert-store-scroll-pos-accidental-removal-of-roving-tab-index

Conversation

@snowystinger
Copy link
Member

#8767

This did a couple too many things, reverting the change that removed our roving tab index. We believe this change is unneeded as the PR suggests with the other two points done.

There are still some issues around focus restore and moving focus that we're considering here #9545

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 3, 2026

@snowystinger snowystinger added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit eaecb96 Feb 3, 2026
29 checks passed
@snowystinger snowystinger deleted the revert-store-scroll-pos-accidental-removal-of-roving-tab-index branch February 3, 2026 16:05
@nwidynski
Copy link
Contributor

@snowystinger what was the issue this caused? i can try to dig up the notes we had on the previous issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants