fix(calendar): prevent setFocusedDate from stealing focus#9463
Open
AryanBagade wants to merge 6 commits intoadobe:mainfrom
Open
fix(calendar): prevent setFocusedDate from stealing focus#9463AryanBagade wants to merge 6 commits intoadobe:mainfrom
AryanBagade wants to merge 6 commits intoadobe:mainfrom
Conversation
Signed-off-by: Aryan Bagade <aryan@aryanbagade.com>
Member
snowystinger
left a comment
There was a problem hiding this comment.
Thanks for the PR! would you mind adding some tests for this so we don't have a regression later?
Signed-off-by: Aryan Bagade <aryan@aryanbagade.com>
Signed-off-by: Aryan Bagade <aryan@aryanbagade.com>
Member
snowystinger
left a comment
There was a problem hiding this comment.
Thanks for the attempt, if you used AI, I think it mislead you. Your tests passed both before and after the change and didn't appear to have anything to do with the changes. I've removed them and added a test for the change.
Member
|
Note to other reviewers, there is a usage in useRangeCalendarState's |
snowystinger
approved these changes
Jan 15, 2026
Member
snowystinger
left a comment
There was a problem hiding this comment.
Checked behaviour against Calendar/RangeCalendar month-and-year-pickers example as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9427
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
Personal contribution (Author : Aryan Bagade aryan.com)