Skip to content

Conversation

@mfrisbey
Copy link
Contributor

Description

Reverts changes done in a previous commit attempting to fix #157. The approach was incorrect and webpack should be used on the consuming library's end.

Reverting the change primarily because it seems it has broken the project's CI so that it's no longer able to release. If still needed, the original fix will need to be reworked.

Fixes #157 (revert)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mfrisbey mfrisbey requested a review from pheenomenon March 19, 2025 19:16
@pheenomenon pheenomenon requested a review from nwoodard-cs March 19, 2025 19:20
Copy link
Contributor

@pheenomenon pheenomenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I wonder why the webpcak changes from previous PR would come in the way of CI release.

@mfrisbey
Copy link
Contributor Author

I wonder why the webpcak changes from previous PR would come in the way of CI release.

After I looked into it further I discovered that it was problems with codecov, which is deprecated. I removed that step from the CI and filed an issue for it. But either way, what I was doing with webpack wasn't correct and should be reverted anyway.

@mfrisbey mfrisbey merged commit 4242183 into master Mar 20, 2025
11 checks passed
@mfrisbey mfrisbey deleted the revert-webpack-config branch March 20, 2025 00:04
@adobe-bot
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library causes errors in webpack

4 participants