Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions buildrunner/docker/multiplatform_image_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,11 @@ def _build_with_inject(
self._log_buildx(logs_itr, platform)

@staticmethod
def _get_image_digest(image_ref: str) -> str:
return docker.buildx.imagetools.inspect(image_ref).config.digest
def _get_image_digest(image_ref: str) -> Optional[str]:
inspect_result = docker.buildx.imagetools.inspect(image_ref)
if not inspect_result or not inspect_result.config:
return None
return inspect_result.config.digest

# pylint: disable=too-many-arguments
@retry(
Expand Down
19 changes: 19 additions & 0 deletions tests/test_multiplatform.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,25 @@ def _actual_images_match_expected(
return missing_images


@pytest.mark.parametrize(
"ret_value",
[
None,
"",
"digest123",
],
)
@patch(
"buildrunner.docker.multiplatform_image_builder.docker.buildx.imagetools.inspect"
)
def test__get_image_digest(inspect_mock, ret_value):
if ret_value is None:
inspect_mock.return_value.config = None
else:
inspect_mock.return_value.config.digest = ret_value
assert MultiplatformImageBuilder._get_image_digest("image1") is ret_value


def test_start_local_registry():
with MultiplatformImageBuilder() as mpib:
mpib._start_local_registry()
Expand Down
Loading