fix: app smoke test failing due to required login#177
Merged
MichaelGoberling merged 1 commit intomasterfrom Jun 16, 2025
Merged
fix: app smoke test failing due to required login#177MichaelGoberling merged 1 commit intomasterfrom
MichaelGoberling merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
App plugin is now outputting web action urls that point to the deploy service -> https://github.com/adobe/aio-e2e-tests/actions/runs/15535392853/job/43733091670#step:11:14 I think in this case we still want them to be adobeio-static urls |
Contributor
Author
dthampy
approved these changes
Jun 16, 2025
shazron
approved these changes
Jun 16, 2025
purplecabbage
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds an authentication step to the app smoke test workflow so that subsequent commands run with a valid Adobe IO login.
- Insert a new “Auth” step using
adobe/aio-apps-action@3.3.0configured via JWT secrets - Ensures the smoke test won’t fail due to missing login
Comments suppressed due to low confidence (3)
.github/workflows/app-smoke-test.yml:39
- Add an explicit
id: authto this step so it’s easy to reference its outputs or status in later steps.
- name: Auth
.github/workflows/app-smoke-test.yml:44
- Verify that the action expects
CLIENTIDin uppercase; many actions use camelCase (e.g.,clientId)—mismatched casing could cause an authentication failure.
CLIENTID: ${{ secrets.JWT_CLIENTID }}
.github/workflows/app-smoke-test.yml:48
- [nitpick] The input name
KEYis very generic. If the action supports it, consider usingPRIVATE_KEYorjwtPrivateKeyto more clearly convey its purpose.
KEY: ${{ secrets.JWT_PRIVATE_KEY }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.