Skip to content

fix: error when current context is undefined, CLI symbol is undefined #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shazron merged 3 commits into from
May 30, 2025
Merged

fix: error when current context is undefined, CLI symbol is undefined #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76be22e
add failing test
shazron May 29, 2025
345d826
fix: error when current ims context is undefined
shazron May 29, 2025
8678b25
CLI reference was undefined
shazron May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/DeployServiceCommand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ const { Flags } = require('@oclif/core')

const { PropertyDefault } = require('./properties')
const runtimeLib = require('@adobe/aio-lib-runtime')
const { getToken, context, CLI } = require('@adobe/aio-lib-ims')
const { getToken, context } = require('@adobe/aio-lib-ims')
const { CLI } = require('@adobe/aio-lib-ims/src/context')
const { getCliEnv } = require('@adobe/aio-lib-env')
const RuntimeBaseCommand = require('./RuntimeBaseCommand')

Expand All @@ -38,7 +39,7 @@ class DeployServiceCommand extends RuntimeBaseCommand {
let contextName = CLI // default
const currentContext = await context.getCurrent() // potential override

if (currentContext !== CLI) {
if (currentContext && currentContext !== CLI) {
contextName = currentContext
} else {
await context.setCli({ 'cli.bare-output': true }, false) // set this globally
Expand Down
4 changes: 2 additions & 2 deletions test/DeployServiceCommand.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ describe('DeployServiceCommand', () => {
getCliEnv.mockReturnValue(mockEnv)
})

test('should use CLI context by default', async () => {
context.getCurrent.mockResolvedValue(CLI)
test('should use CLI context (default) if current context undefined', async () => {
context.getCurrent.mockResolvedValue(undefined)
getToken.mockResolvedValue(mockToken)

const result = await command.getAccessToken()
Expand Down