Skip to content

Conversation

@SteversIO
Copy link

@SteversIO SteversIO commented May 31, 2022

Adds new enum type to prevent critical bug when deserializing to unknown TypeEnum.

Description

Added new enum.

Related Issue

Fixes Issue #8

Motivation and Context

This change prevents legacy code from breaking. We, along with presumably many others, have code that up until this point, has been working pretty flawlessly. At some point Adobe introduced a contract breaking change and did not update this library.

How Has This Been Tested?

Since there are no tests in source code for TypeEnum, we performed manual testing. We have our own tests in our own source code that verify the code works.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Tests are commented out. So last two checkboxes are tautologically true.

@junjung929
Copy link

junjung929 commented Aug 2, 2022

Hi @SteversIO,
I am also having similar error because of a missing type enum. Could you also add "SIGNER_NAME_CHANGED_BY_SIGNER" in your solution?
Thank you!

@moto-geek
Copy link

moto-geek commented Nov 14, 2022

Appears Adobesign has been adding quite a few new statuses. Might have to change this solution to allow dynamic changes to statuses to avoid enum nullable types.

Another one to add to the enums. "DOCUMENTS_VIEWED_HOSTED"

Exception message: Error converting value "DOCUMENTS_VIEWED_HOSTED" to type 'System.Nullable`1[ AdobeSign.RESTApi.model.agreements.AgreementEvent+TypeEnum]'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants