feat: support reading markdown#29
Open
sharanyavinod wants to merge 5 commits into
Open
Conversation
anfibiacreativa
requested changes
May 15, 2026
Member
|
@sharanyavinod you will need to update this PR to target the modularized agent that already landed, if applicable. |
| return item.mediaType === 'text/markdown' || item.fileName.toLowerCase().endsWith('.md'); | ||
| } | ||
|
|
||
| const MAX_INLINE_BYTES = 50_000; |
Member
There was a problem hiding this comment.
I am curious why 50KB? i may have missed this before. Should we have the option to bump it via config? wdyt @mhaack
Collaborator
Author
There was a problem hiding this comment.
No reason, kept a dummy threshold we can increase or throw out if needed and this seemed a reasonable starting point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user attaches a .md / text/markdown file with dataBase64, the agent now decodes and inlines the content directly into the system prompt rather than treating it as an opaque upload. The model can read the file immediately; content_upload is still suggested but only needed if the file should be persisted to DA. All other file types remain upload-only. Docs updated accordingly.