docs(access-rule-model): declare IDTA-01002 as SoT for formula grammar (T-01)#83
Open
aorzelskiGH wants to merge 1 commit into
Open
docs(access-rule-model): declare IDTA-01002 as SoT for formula grammar (T-01)#83aorzelskiGH wants to merge 1 commit into
aorzelskiGH wants to merge 1 commit into
Conversation
Add an IMPORTANT block next to the cross-reference to the Query Language chapter that explicitly names IDTA-01002 (Query Language chapter and its JSON Schema) as the normative single source of truth for shared formula productions. This specification (IDTA-01004) only adds Access-Rule-specific productions (ACL, OBJECTS, RIGHTS, ACCESS, ROUTE, FILTER, DEFATTRIBUTES, DEFACLS, DEFOBJECTS, DEFFORMULAS, ...) on top of the shared grammar. Bugfixes to shared productions in IDTA-01002 are automatically inherited. Refs: Review Finding T-01 Made-with: Cursor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| *Single source of truth.* The BNF grammar and JSON Schema productions for *formula expressions* (logical expressions, comparisons, FieldIdentifiers, value literals, operands, type casts, and `$match` / `$and` / `$or` / `$not` operators) are *normatively defined in IDTA-01002 Part 2* (Query Language chapter and its JSON Schema). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an IMPORTANT block to the Access Rule Model chapter that names IDTA-01002 (Query Language chapter and its JSON Schema) as the normative single source of truth for all shared formula productions.
Problem
Today IDTA-01002 and IDTA-01004 ship duplicated BNF fragments and JSON Schema blocks for formula expressions (logical expressions, comparisons, FieldIdentifiers, value literals, type casts,
$match/$and/$or/$not). The two copies are maintained in parallel but no text states which one is authoritative, which has led to recurring drift (e.g.timeLiteralPattern,$dayOfWeekrefs,supplementalSemanticIds).Solution
IMPORTANTblock right after the existing cross-reference to the Query Language chapter.ACL,OBJECTS,RIGHTS,ACCESS,ROUTE,FILTER,DEFATTRIBUTES,DEFACLS,DEFOBJECTS,DEFFORMULAS, ...) on top of the shared grammar.Affected files
documentation/IDTA-01004/modules/ROOT/pages/access-rule-model.adocReview notes
aas-specs-apiadds the mirrored normative subsection.Refs: Review Finding T-01