Skip to content

Align all example CMake targets with C++17 library standard#11

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/update-example-cmakelists-to-c17
Draft

Align all example CMake targets with C++17 library standard#11
Copilot wants to merge 2 commits into
mainfrom
copilot/update-example-cmakelists-to-c17

Conversation

Copy link
Copy Markdown

Copilot AI commented May 9, 2026

The library builds with C++17, while most examples were still forcing C++11, creating a language-standard mismatch between headers/library and example consumers. This PR removes that drift by standardizing all example CMake targets on C++17.

  • Scope

    • Updated all affected examples/**/CMakeLists.txt files that still declared -std=c++11.
    • Left already-aligned paths out of scope (no churn outside impacted files).
  • CMake standardization

    • Replaced hardcoded C++11 compiler flag usage with explicit CMake standard settings.
    • Kept existing optimization flags intact.
  • Resulting pattern

    set(CMAKE_CXX_STANDARD 17)
    set(CMAKE_CXX_STANDARD_REQUIRED ON)
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3")

Copilot AI changed the title [WIP] Update all example CMakeLists.txt files to use C++17 Align all example CMake targets with C++17 library standard May 9, 2026
Copilot AI requested a review from adityakamath May 9, 2026 20:42
Copy link
Copy Markdown
Owner

@adityakamath adityakamath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source code has been updated for scs009, see if more cmake targets need to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all example CMakeLists.txt files to use C++17 to match library standard

2 participants