Open
Conversation
Owner
|
This looks good! I am away from my computer but can get this merged and published later today |
Author
|
Hi @addisonj could you approve the pull request and publish the module? 🙏 |
Owner
|
Dang! Sorry to have spaced this for so long,I blame the holidays.... I noticed one latent semicolon in the test fixture and forgot to circle Thanks for the reminder! On Wed, Jan 6, 2016, 3:07 PM Eugenio notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes yo need to avoid cache on certains errors;