Implement ADCP 2.12.0 template formats #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 5 template formats (display_generative, display_image, display_html, video_standard, video_dimensions) that accept parameterized dimensions or duration, reducing the need for hundreds of concrete formats. Maintains full backward compatibility with all 42 existing concrete formats. Includes comprehensive test coverage with 44 new tests validating template format behavior, parameter extraction, and asset requirements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
force-pushed
the
template-formats-review
branch
from
6a69da1 to
1693e70
Compare
- Use FormatIdParameter enum instead of strings for accepts_parameters - Add null checks for fmt.accepts_parameters before using 'in' operator - Add null check for render.dimensions before accessing width/height - Ensures type safety while maintaining all functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements ADCP 2.12.0 template formats to eliminate format explosion. Adds 5 template formats (display_generative, display_image, display_html, video_standard, video_dimensions) that accept parameterized dimensions or duration instead of requiring separate concrete formats for each size.
Changes:
Result: 47 total formats (5 templates + 42 concrete) vs potential 90+ formats without templates.
Test plan
🤖 Generated with Claude Code