fix: industry alerts not posting to Slack channels #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hasAlertedPerspective()` check was blocking articles from being posted to real Slack channels if they had already been posted to website-only channels. The function checked if a perspective was alerted to ANY channel, but the SQL query already handles per-channel deduplication via the NOT EXISTS clause with channel_id filter. Changes: - Remove redundant hasAlertedPerspective() call from processAlerts() - Remove unused hasAlertedPerspective() function - Remove unused getPerspectivesToAlert() function (had same bug) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Jan 6, 2026
* fix: industry alerts not posting to Slack channels The `hasAlertedPerspective()` check was blocking articles from being posted to real Slack channels if they had already been posted to website-only channels. The function checked if a perspective was alerted to ANY channel, but the SQL query already handles per-channel deduplication via the NOT EXISTS clause with channel_id filter. Changes: - Remove redundant hasAlertedPerspective() call from processAlerts() - Remove unused hasAlertedPerspective() function - Remove unused getPerspectivesToAlert() function (had same bug) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: sync package-lock.json version 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hasAlertedPerspective()check was blocking articles that had already been posted to website-only channelshasAlertedPerspective,getPerspectivesToAlert)Root Cause
The
hasAlertedPerspective()function checked if a perspective was alerted to ANY channel, but the intended behavior was per-channel deduplication. This meant if an article was posted to aWEBSITE_ONLY_*channel first, it would never be posted to real Slack channels likeC0A6J6RTTEY(Industry Agentic News).The SQL query in
getNextArticleForChannel()already handles this correctly with:Test plan
🤖 Generated with Claude Code