Skip to content

fix(docs): use serve_window_sec in TMP Identity Match overview example#4474

Closed
brandonling27 wants to merge 1 commit into
adcontextprotocol:mainfrom
brandonling27:fix/tmp-identity-match-response-example-ling
Closed

fix(docs): use serve_window_sec in TMP Identity Match overview example#4474
brandonling27 wants to merge 1 commit into
adcontextprotocol:mainfrom
brandonling27:fix/tmp-identity-match-response-example-ling

Conversation

@brandonling27
Copy link
Copy Markdown

Summary

  • The overview walkthrough's identity_match_response example used the legacy ttl_sec field, which fails schema validation — the schema requires serve_window_sec.
  • The two fields are not synonyms: serve_window_sec is a per-package single-shot fcap (the publisher must re-query Identity Match after serving once per eligible package), not a router response cache TTL. Updated the example's accompanying explanation to reflect this.
  • Updated the matching fixture in tests/example-validation-simple.test.cjs so the TMP Identity Match response — web (overview walkthrough) case validates against the schema.

Note: the same ttl_sec vs. serve_window_sec drift exists in the surface walkthroughs (surfaces/web.mdx, surfaces/mobile.mdx, surfaces/ctv.mdx, surfaces/retail-media.mdx, surfaces/ai-assistants.mdx) and in context-and-identity.mdx. Those aren't covered by the current validation test and are left for a follow-up to keep this PR scoped to the failing test.

Test plan

  • node tests/example-validation-simple.test.cjs — 36/36 passing; the previously failing TMP Identity Match response — web (overview walkthrough) case now passes.
  • Mintlify renders docs/trusted-match/index.mdx Step 4 cleanly with the new explanation.

🤖 Generated with Claude Code

The overview walkthrough's identity_match_response example used the legacy
ttl_sec field, which fails schema validation — serve_window_sec is the
required field and carries different semantics (per-package single-shot
fcap, not a router cache TTL). Update the docs example, its accompanying
explanation, and the corresponding test fixture to match the schema.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@aao-ipr-bot
Copy link
Copy Markdown

aao-ipr-bot Bot commented May 12, 2026

IPR Policy Agreement Required

@brandonling27 — thanks for the contribution. Before this PR can be merged, the AgenticAdvertising.Org IPR Policy requires your agreement.

To agree, post a new comment on this PR with the exact phrase:

I have read the IPR Policy

Your signature is recorded once and covers all contributions to AAO repositories. See signatures/README.md for what gets recorded and why.

@brandonling27 brandonling27 marked this pull request as draft May 12, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants