fix(tmp): update Identity Match response example — missing serve_window_sec field#4469
Conversation
…ow_sec field The TMP Identity Match response example was not updated when the schema changed in adcontextprotocol#4070 to replace ttl_sec with serve_window_sec. This fix updates the test example to use the new required field. Fixes the test failure: "TMP Identity Match response — web (overview walkthrough)" Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
IPR Policy Agreement Required@AndyBevan — thanks for the contribution. Before this PR can be merged, the AgenticAdvertising.Org IPR Policy requires your agreement. To agree, post a new comment on this PR with the exact phrase: Your signature is recorded once and covers all contributions to AAO repositories. See |
|
I have read the IPR Policy |
IPR Policy — signedThanks, @AndyBevan. Your agreement to the IPR Policy is recorded at |
|
@AndyBevan what about Note: the same ttl_sec mismatch exists in five other surface docs (surfaces/web.mdx, surfaces/mobile.mdx, surfaces/ctv.mdx, surfaces/retail-media.mdx, surfaces/ai-assistants.mdx, plus context-and-identity.mdx) |
… ttl_sec to serve_window_sec Update all TMP documentation to use serve_window_sec instead of ttl_sec in Identity Match response examples and explanations. This aligns with the schema change in adcontextprotocol#4070 where ttl_sec was replaced with serve_window_sec as the per-package single-shot frequency-cap window field. Updated files: - docs/trusted-match/index.mdx - docs/trusted-match/context-and-identity.mdx - docs/trusted-match/router-architecture.mdx - docs/trusted-match/surfaces/ai-assistants.mdx - docs/trusted-match/surfaces/ctv.mdx - docs/trusted-match/surfaces/mobile.mdx - docs/trusted-match/surfaces/retail-media.mdx - docs/trusted-match/surfaces/web.mdx Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
@brandonling27 - I actually found 8 places so fixed all of them - if any of these aren't right let me know and I'll adjust. |
LGTM |
2 participants
Summary
Update the TMP Identity Match response test example to use the new
serve_window_secfield introduced in #4070.Problem
The test suite was failing with:
❌ TMP Identity Match response — web (overview walkthrough): root: must have required property 'serve_window_sec'
The schema was updated in #4070 to replace
ttl_secwith the newserve_window_secfield (per-package single-shot frequency-cap window), but the test example intests/example-validation-simple.test.cjswas not updated.
Solution
Updated the test example at line 584 to use
serve_window_sec: 60instead ofttl_sec: 60.Testing
Related Issues