spec(comply_test_controller): require account.sandbox: true (closes #4383)#4392
Open
bokelley wants to merge 2 commits into
Open
spec(comply_test_controller): require account.sandbox: true (closes #4383)#4392bokelley wants to merge 2 commits into
bokelley wants to merge 2 commits into
Conversation
…4383) - Sweep all 25 comply_test_controller sample_request blocks across 6 storyboard YAMLs to include account: { sandbox: true }. - Tighten static/schemas/source/compliance/comply-test-controller-request.json to require account at the top level. Description promoted from SHOULD to MUST; the (Sandbox) verdict tier (#4379) now has schema backing. - Add account assertion to schema examples so docs and validators stay in sync. The existing storyboard sample_request schema lint (scripts/lint-storyboard-sample-request-schema.cjs, surfaced via tests/lint-storyboard-sample-request-schema.test.cjs) catches future omissions: any new comply_test_controller step lacking account fingerprints as required@/:account, blocking CI without an allowlist entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage proof
```
total comply_test_controller: 25
with account.sandbox: true: 25
```
Lint coverage for future additions
The existing storyboard sample_request schema lint at `scripts/lint-storyboard-sample-request-schema.cjs` (wrapped by `tests/lint-storyboard-sample-request-schema.test.cjs`) runs ajv against every storyboard sample_request. With `account` now in the request schema's `required` array, any future `comply_test_controller` step missing `account` fingerprints as `required@/:account` and fails CI without an allowlist entry. No new lint code needed — the schema tightening is what unlocks the gate.
Test plan
Closes #4383.
🤖 Generated with Claude Code