-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Implement AdCP v2.6 Support #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The security audit showing a new issue github vulnerability scan |
|
let's update the test framework that Addie or command line can use to try sending requests with and without required assets to flag to developers that they're using a field that won't be supported in the future |
- Add warnings field to TestStepResult type - Detect deprecated assets_required usage in discoverCreativeFormats - Display warnings in formatter output and summary - Add unit tests for deprecation detection
502e500 to
bcd26db
Compare
AdCP v2.6.0 schema added additionalProperties: true to many types for extensibility, increasing index signatures from 29→101 (tools) and 15→73 (core). This is intentional for forward compatibility.
When calling list_creative_formats, CLI now warns if formats use the deprecated assets_required field instead of the new assets field. - Pretty output: Shows warning with affected format names - JSON output: Includes warnings array in response
f6a5f07 to
1e197eb
Compare
cafba51 to
71c7ec2
Compare
- Server: Add usesDeprecatedAssetsField check to /api/creative/list-formats - UI: Display yellow warning box when formats use deprecated assets_required
71c7ec2 to
8b636ce
Compare
youbek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm


Summary
Updates the client library to support AdCP protocol version 2.6, including the new assets field in Format schema with backward compatibility for deprecated assets_required.
Adcp client version
3.5.2->3.6.0What's New in AdCP v2.6
Changes
test html pageTesting UI
Tests
Added 21 unit tests for format-assets utilities
Migration
v2.6 agents (using assets)
v2.5 agents (using assets_required)
assets_requiredwill be still supportedassetsfield