Skip to content

Conversation

@BaiyuScope3
Copy link
Collaborator

@BaiyuScope3 BaiyuScope3 commented Jan 6, 2026

Summary

Updates the client library to support AdCP protocol version 2.6, including the new assets field in Format schema with backward compatibility for deprecated assets_required.

Adcp client version 3.5.2 -> 3.6.0

What's New in AdCP v2.6

  • Format schema: New assets field replaces deprecated assets_required
  • Asset required flag: Explicit required: boolean allows both required AND optional assets
  • Backward compatible helps: Library handles both old and new schema versions and providing helper for it

Changes

  • Library (v3.5.2 → v3.6.0)
  • New format-assets utilities for v2.5/v2.6 compatibility
  • Updated testing framework to use new utilities
  • Synced schemas and types to v2.6
  • BUG FIX: Added URL input option for image/video assets in test html page

Testing UI

  • BUG FIX: Added URL input option for image/video assets
  • Updated to use getFormatAssets() helper

Tests

Added 21 unit tests for format-assets utilities

Migration

  1. No action required - when user switch to use the helper function, the library automatically handles both:
    v2.6 agents (using assets)
    v2.5 agents (using assets_required)
  2. the assets_required will be still supported
  3. the schema has been loosen to accept extra fields [PR] (thanks @bokelley !) , so old agent that didn't update adcp client, it won't break with newly added assets field

@BaiyuScope3 BaiyuScope3 changed the title Update 2 6 adcp featUpdate 2 6 adcp Jan 6, 2026
@BaiyuScope3 BaiyuScope3 changed the title featUpdate 2 6 adcp feat: Update client to use 2_6 adcp protocol schema Jan 6, 2026
@BaiyuScope3 BaiyuScope3 changed the title feat: Update client to use 2_6 adcp protocol schema feat: Implement AdCP v2.6 Support Jan 6, 2026
@BaiyuScope3 BaiyuScope3 marked this pull request as ready for review January 6, 2026 21:34
@BaiyuScope3
Copy link
Collaborator Author

BaiyuScope3 commented Jan 6, 2026

The security audit showing a new issue github vulnerability scan
GHSA-8r9q-7v3j-jr4g
We might need to update MCP TypeScript SDK to 1.25.2+ in all of our repos (agentic api, sales agent, creative agent, adcp client)

@bokelley
Copy link
Contributor

bokelley commented Jan 7, 2026

let's update the test framework that Addie or command line can use to try sending requests with and without required assets to flag to developers that they're using a field that won't be supported in the future

- Add warnings field to TestStepResult type
- Detect deprecated assets_required usage in discoverCreativeFormats
- Display warnings in formatter output and summary
- Add unit tests for deprecation detection
@BaiyuScope3 BaiyuScope3 force-pushed the update_2_6_adcp branch 2 times, most recently from 502e500 to bcd26db Compare January 8, 2026 00:09
AdCP v2.6.0 schema added additionalProperties: true to many types
for extensibility, increasing index signatures from 29→101 (tools)
and 15→73 (core). This is intentional for forward compatibility.
When calling list_creative_formats, CLI now warns if formats use the
deprecated assets_required field instead of the new assets field.

- Pretty output: Shows warning with affected format names
- JSON output: Includes warnings array in response
@BaiyuScope3
Copy link
Collaborator Author

BaiyuScope3 commented Jan 8, 2026

Both CLI and Addie test and test UI will show warning message for using deprecated fields
Test UI:
image
CLI:
image

- Server: Add usesDeprecatedAssetsField check to /api/creative/list-formats
- UI: Display yellow warning box when formats use deprecated assets_required
Copy link
Collaborator

@youbek youbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants