fix(ui): Display CPM pricing from pricing_options #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UI was looking for `product.cpm` (deprecated field) but the AdCP spec moved pricing to `pricing_options[].rate`. This fix: - Updates `formatCPM()` to extract rate from `pricing_options[0].rate` - Handles auction pricing via `pricing_options[0].price_guidance.p75` - Falls back to deprecated `product.cpm` for backwards compatibility - Adds null safety and improves display when pricing is unavailable - Uses `~$` prefix for auction guidance prices to indicate estimate 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bokelley
force-pushed
the
bokelley/fix-cpm-pricing-display
branch
from
b3ffd94 to
7aa38ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
formatCPM()function to extract rate from AdCP spec'spricing_options[0].ratefieldpricing_options[0].price_guidance.p75product.cpmfieldProblem
The UI was looking for
product.cpm(a deprecated field), but the AdCP spec moved pricing topricing_options[].rate. Products were displaying "Contact for pricing" even when valid pricing data was returned in thepricing_optionsarray.Test plan
pricing_options[0].ratedisplay correct price (e.g.,$6.01)~$Xformatcpmfield still work🤖 Generated with Claude Code